Re: tie bug in 2.13.10?

classic Classic list List threaded Threaded
14 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: tie bug in 2.13.10?

Federico Bruni
Il 03/01/2010 00:25, Trevor Daniels ha scritto:
> It was caused by my changes.  Sorry :(
> I've just pushed a fix.

I've compiled 2.13.11 from Git right now.
The bug is gone, but it's still there if I use bend.ly and a command
created to hide notes and fret numbers. (see attached file)

Can you fix it as well?
Or should I change something in my input?

Thanks,
Federico
--
http://gnurag.net/blog/
http://fsfe.org/
http://groups.fsf.org/wiki/LibrePlanetItalia


white-tabhead.ly (878 bytes) Download Attachment
bend.ly (28K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: tie bug in 2.13.10?

Marc Hohl
Federico Bruni schrieb:
> Il 03/01/2010 00:25, Trevor Daniels ha scritto:
>> It was caused by my changes.  Sorry :(
>> I've just pushed a fix.
>
Hi Federico,

Trevor has enabled a whiteout property, which has to be set to #f,
so every appearance of

\once \override TabNoteHead #'transparent = ##t

should be followed by

\once \override TabNoteHead #'whiteout = ##f

in white-tabhead.ly

and every

(ly:grob-set-property! right-tab-note-head 'transparent #t)

should be followed by

(ly:grob-set-property! right-tab-note-head 'whiteout #f)

in bend.ly.

HTH

Marc




> I've compiled 2.13.11 from Git right now.
> The bug is gone, but it's still there if I use bend.ly and a command
> created to hide notes and fret numbers. (see attached file)
>
> Can you fix it as well?
> Or should I change something in my input?
>
> Thanks,
> Federico



Reply | Threaded
Open this post in threaded view
|

Re: tie bug in 2.13.10?

Carl Sorensen



On 1/12/10 9:41 AM, "Marc Hohl" <[hidden email]> wrote:

> Federico Bruni schrieb:
>> Il 03/01/2010 00:25, Trevor Daniels ha scritto:
>>> It was caused by my changes.  Sorry :(
>>> I've just pushed a fix.
>>
> Hi Federico,
>
> Trevor has enabled a whiteout property, which has to be set to #f,
> so every appearance of
>
> \once \override TabNoteHead #'transparent = ##t
>
> should be followed by
>
> \once \override TabNoteHead #'whiteout = ##f
>
> in white-tabhead.ly

This seems to me to call for a new variable

hideTabNoteHead = {
  \once \override TabNoteHead #'transparent = ##t
  \once \override TabNoteHead #'whiteout = ##f
}

and to replace

\once \override TabNoteHead #'transparent = ##t

with

\hideTabNoteHead


>
> and every
>
> (ly:grob-set-property! right-tab-note-head 'transparent #t)
>
> should be followed by
>
> (ly:grob-set-property! right-tab-note-head 'whiteout #f)
>
> in bend.ly.

Similarly, we should have

(define (hide-tab-note-head note-head)
  (ly:grob-set-property! note-head 'whiteout #f)
  (ly:grob-set-property! note-head 'transparent #t))

and replace

(ly:grob-set-property! right-tab-note-head 'transparent #t)

with

(hide-tab-note-head right-tab-note-head)


On a related note, Marc, why do you want to use ly:grob-set-property!
instead of using an override function?

Thanks,

Carl



Reply | Threaded
Open this post in threaded view
|

Re: tie bug in 2.13.10?

Federico Bruni
In reply to this post by Marc Hohl
Il 12/01/2010 17:41, Marc Hohl ha scritto:

> Hi Federico,
>
> Trevor has enabled a whiteout property, which has to be set to #f,
> so every appearance of
>
> \once \override TabNoteHead #'transparent = ##t
>
> should be followed by
>
> \once \override TabNoteHead #'whiteout = ##f
>
> in white-tabhead.ly

thanks, it works

>
> and every
>
> (ly:grob-set-property! right-tab-note-head 'transparent #t)
>
> should be followed by
>
> (ly:grob-set-property! right-tab-note-head 'whiteout #f)
>
> in bend.ly.
>

yes, it works as well :-)

thank you so much

Just to know..
the development of bend.ly is terminated? I mean, you are working to
put bendings in the core of lilyPond, so I guess you are not going to
maintain or update this file anymore, am I right? (as you did with
tablature.ly)


Federico
--
http://gnurag.net/blog/
http://fsfe.org/
http://groups.fsf.org/wiki/LibrePlanetItalia



Reply | Threaded
Open this post in threaded view
|

Re: tie bug in 2.13.10?

Marc Hohl
In reply to this post by Carl Sorensen
Carl Sorensen schrieb:

>
>  
>
> This seems to me to call for a new variable
>
> hideTabNoteHead = {
>   \once \override TabNoteHead #'transparent = ##t
>   \once \override TabNoteHead #'whiteout = ##f
> }
>
> and to replace
>
> \once \override TabNoteHead #'transparent = ##t
>
> with
>
> \hideTabNoteHead
>
>
>  
This should go to ly/property-init then, right?

Should I create a patch? Has this to be documented somewhere
in the docs?

>> and every
>>
>> (ly:grob-set-property! right-tab-note-head 'transparent #t)
>>
>> should be followed by
>>
>> (ly:grob-set-property! right-tab-note-head 'whiteout #f)
>>
>> in bend.ly.
>>    
>
> Similarly, we should have
>
> (define (hide-tab-note-head note-head)
>   (ly:grob-set-property! note-head 'whiteout #f)
>   (ly:grob-set-property! note-head 'transparent #t))
>
> and replace
>
> (ly:grob-set-property! right-tab-note-head 'transparent #t)
>
> with
>
> (hide-tab-note-head right-tab-note-head)
>
>
> On a related note, Marc, why do you want to use ly:grob-set-property!
> instead of using an override function?
>  
This is used in bend.ly, which has alpha status, and since we
want to do bends by a new engraver, I don't think it makes
sense to enhance this file.

Marc
> Thanks,
>
> Carl
>
>
>  



Reply | Threaded
Open this post in threaded view
|

Re: tie bug in 2.13.10?

Marc Hohl
In reply to this post by Federico Bruni
Federico Bruni schrieb:

> Il 12/01/2010 17:41, Marc Hohl ha scritto:
>> Hi Federico,
>>
>> Trevor has enabled a whiteout property, which has to be set to #f,
>> so every appearance of
>>
>> \once \override TabNoteHead #'transparent = ##t
>>
>> should be followed by
>>
>> \once \override TabNoteHead #'whiteout = ##f
>>
>> in white-tabhead.ly
>
> thanks, it works
>
>>
>> and every
>>
>> (ly:grob-set-property! right-tab-note-head 'transparent #t)
>>
>> should be followed by
>>
>> (ly:grob-set-property! right-tab-note-head 'whiteout #f)
>>
>> in bend.ly.
>>
>
> yes, it works as well :-)
>
> thank you so much
>
> Just to know..
> the development of bend.ly is terminated? I mean, you are working to
> put bendings in the core of lilyPond, so I guess you are not going to
> maintain or update this file anymore, am I right? (as you did with
> tablature.ly)
Hi Federico,

yes, you are right. Perhaps the will be some intermediate states for
testing, but it seems that
bends need c++, so it isn't possible to simply include a .ly file any more.
On the other hand, while things are developing, if there are any changes
in lilypond which affect
the functionality of bend.ly, I think we should amend that, so that
bend.ly is working until the
native bend support is working.

Greetings

Marc
>
>
> Federico



Reply | Threaded
Open this post in threaded view
|

Re: tie bug in 2.13.10?

Carl Sorensen
In reply to this post by Marc Hohl



On 1/13/10 1:05 AM, "Marc Hohl" <[hidden email]> wrote:

> Carl Sorensen schrieb:
>>
>>  
>>
>> This seems to me to call for a new variable
>>
>> hideTabNoteHead = {
>>   \once \override TabNoteHead #'transparent = ##t
>>   \once \override TabNoteHead #'whiteout = ##f
>> }
>>
>> and to replace
>>
>> \once \override TabNoteHead #'transparent = ##t
>>
>> with
>>
>> \hideTabNoteHead
>>
>>
>>  
> This should go to ly/property-init then, right?
>
> Should I create a patch? Has this to be documented somewhere
> in the docs?

Do you intend for this to be used by users?  If so, it would go in
ly/property-init.ly and should be documented.  A single paragraph and a
simple snippet in the tablature section would suffice.  It would be great if
you could create a patch.

>>> and every
>>>
>>> (ly:grob-set-property! right-tab-note-head 'transparent #t)
>>>
>>> should be followed by
>>>
>>> (ly:grob-set-property! right-tab-note-head 'whiteout #f)
>>>
>>> in bend.ly.
>>>    
>>
>> Similarly, we should have
>>
>> (define (hide-tab-note-head note-head)
>>   (ly:grob-set-property! note-head 'whiteout #f)
>>   (ly:grob-set-property! note-head 'transparent #t))
>>
>> and replace
>>
>> (ly:grob-set-property! right-tab-note-head 'transparent #t)
>>
>> with
>>
>> (hide-tab-note-head right-tab-note-head)
>>
>>
>> On a related note, Marc, why do you want to use ly:grob-set-property!
>> instead of using an override function?
>>  
> This is used in bend.ly, which has alpha status, and since we
> want to do bends by a new engraver, I don't think it makes
> sense to enhance this file.

Sounds great to me.

Thanks,

Carl



Reply | Threaded
Open this post in threaded view
|

Re: tie bug in 2.13.10?

james.lowe@datacore.com
CONTENTS DELETED
The author has deleted this message.
Reply | Threaded
Open this post in threaded view
|

Re: tie bug in 2.13.10?

Marc Hohl
J_ames schrieb:

> Hello,
>
> My name is James and I have been tasked by Graham Percival (who has been
> mentoring me in regards to Documentation of LilyPond) to ask about a
> requested document change by Federico concerning the tab-example.ly file.
>
> Reading this thread it seems to me that as of today \include bend.ly would
> be appropriate however there are plans to add this to the 'core engraver' so
> that when 2.14 is out there will be no need for this include file.
>
> Is this right/true/still in the air etc?
>  
I am currently working on this, but still struggling with the basics...
I don't know when 2.14 will be released, but I hope things go fast enough
to have a proper implementation of bends, so bend.ly will not appear in
any release.

Marc

> I'd just like to get this straight so I don't do unnecessary patching of
> documentation.
>
> Thanks for your time
>
> James
>
>
>  
>> Carl Sorensen schrieb:
>> This is used in bend.ly, which has alpha status, and since we
>> want to do bends by a new engraver, I don't think it makes
>> sense to enhance this file.
>>    
>
>  



Reply | Threaded
Open this post in threaded view
|

RE: tie bug in 2.13.10?

james.lowe@datacore.com
CONTENTS DELETED
The author has deleted this message.
Reply | Threaded
Open this post in threaded view
|

Re: tie bug in 2.13.10?

Marc Hohl
James Lowe schrieb:
> Marc,
>
> Thanks for this.
>
> I think that clarifies things for us, I will make the simple edits that Federico first suggested so I won't bother an overly complicated example.ly for now.
>  
Sounds reasonable.
> If we need to revisit this we can. Else we'll just wait for what happens with the 2.14 release.
>
> Good luck!
>
>  
Thanks!

Marc



Reply | Threaded
Open this post in threaded view
|

Re: [tablatures] tie bug in 2.13.10?

Marc Hohl
In reply to this post by Carl Sorensen
Carl Sorensen schrieb:

>
> On 1/13/10 1:05 AM, "Marc Hohl" <[hidden email]> wrote:
>
>  
>> Carl Sorensen schrieb:
>>    
>>>  
>>>
>>> This seems to me to call for a new variable
>>>
>>> hideTabNoteHead = {
>>>   \once \override TabNoteHead #'transparent = ##t
>>>   \once \override TabNoteHead #'whiteout = ##f
>>> }
>>>
>>> and to replace
>>>
>>> \once \override TabNoteHead #'transparent = ##t
>>>
>>> with
>>>
>>> \hideTabNoteHead
>>>
>>>
>>>  
>>>      
>> This should go to ly/property-init then, right?
>>
>> Should I create a patch? Has this to be documented somewhere
>> in the docs?
>>    
>
> Do you intend for this to be used by users?  If so, it would go in
> ly/property-init.ly and should be documented.  A single paragraph and a
> simple snippet in the tablature section would suffice.  It would be great if
> you could create a patch.
>
>  
Looking more carefully at the definitions for hideNote in
ly/property-init.ly,
I am not sure how to incude that in a proper way. Is \hideTabNoteHead
meant to make only sense in default tablature settings (i.e. without
stems and stuff)?
I think this makes sense, but I am not 100% sure.

Should we define it as mentioned above, or should there be some
\hideTabNote ... \unHideTabNote pair, or better
\hideTabNoteHead ... \unHideTabNoteHead?

Marc



Reply | Threaded
Open this post in threaded view
|

Re: [tablatures] tie bug in 2.13.10?

Carl Sorensen



On 1/25/10 3:32 AM, "Marc Hohl" <[hidden email]> wrote:

> Carl Sorensen schrieb:
>>
>> On 1/13/10 1:05 AM, "Marc Hohl" <[hidden email]> wrote:
>>
>>  
>>> Carl Sorensen schrieb:
>>>    
>>>>
>>>>
>>>> This seems to me to call for a new variable
>>>>
>>>> hideTabNoteHead = {
>>>>   \once \override TabNoteHead #'transparent = ##t
>>>>   \once \override TabNoteHead #'whiteout = ##f
>>>> }
>>>>
>>>> and to replace
>>>>
>>>> \once \override TabNoteHead #'transparent = ##t
>>>>
>>>> with
>>>>
>>>> \hideTabNoteHead
>>>>
>>>>
>>>>
>>>>      
>>> This should go to ly/property-init then, right?
>>>
>>> Should I create a patch? Has this to be documented somewhere
>>> in the docs?
>>>    
>>
>> Do you intend for this to be used by users?  If so, it would go in
>> ly/property-init.ly and should be documented.  A single paragraph and a
>> simple snippet in the tablature section would suffice.  It would be great if
>> you could create a patch.
>>
>>  
> Looking more carefully at the definitions for hideNote in
> ly/property-init.ly,
> I am not sure how to incude that in a proper way.

The command in ly/property-init.ly is hideNotes (plural), so it uses
hideNotes and unHideNotes.

As far as I can see, hideTabNoteHead is to be used only for a single note
(i.e., the tied tab-note-head), so I think it should remain a \once
\override command and should not be part of a pair.

But if this is not intended to be called by the user, then I don't think it
necessarily needs to go in property-init.ly.  I can't give a good
recommendation yet, because I'm not clear enough on how this will be used.

For right now, you might want to define \hideTabNoteHead in tablatures.ly,
rather than property-init.ly.

HTH,

Carl



Reply | Threaded
Open this post in threaded view
|

Re: [tablatures] tie bug in 2.13.10?

Marc Hohl
Carl Sorensen schrieb:

>
> On 1/25/10 3:32 AM, "Marc Hohl" <[hidden email]> wrote:
>
>  
>> Carl Sorensen schrieb:
>>    
>>> On 1/13/10 1:05 AM, "Marc Hohl" <[hidden email]> wrote:
>>>
>>>  
>>>      
>>>> Carl Sorensen schrieb:
>>>>    
>>>>        
>>>>> This seems to me to call for a new variable
>>>>>
>>>>> hideTabNoteHead = {
>>>>>   \once \override TabNoteHead #'transparent = ##t
>>>>>   \once \override TabNoteHead #'whiteout = ##f
>>>>> }
>>>>>
>>>>> and to replace
>>>>>
>>>>> \once \override TabNoteHead #'transparent = ##t
>>>>>
>>>>> with
>>>>>
>>>>> \hideTabNoteHead
>>>>>
>>>>>
>>>>>
>>>>>      
>>>>>          
>>>> This should go to ly/property-init then, right?
>>>>
>>>> Should I create a patch? Has this to be documented somewhere
>>>> in the docs?
>>>>    
>>>>        
>>> Do you intend for this to be used by users?  If so, it would go in
>>> ly/property-init.ly and should be documented.  A single paragraph and a
>>> simple snippet in the tablature section would suffice.  It would be great if
>>> you could create a patch.
>>>
>>>  
>>>      
>> Looking more carefully at the definitions for hideNote in
>> ly/property-init.ly,
>> I am not sure how to incude that in a proper way.
>>    
>
> The command in ly/property-init.ly is hideNotes (plural), so it uses
> hideNotes and unHideNotes.
>  
Ah, I missed that. Sorry.
> As far as I can see, hideTabNoteHead is to be used only for a single note
> (i.e., the tied tab-note-head), so I think it should remain a \once
> \override command and should not be part of a pair.
>
> But if this is not intended to be called by the user, then I don't think it
> necessarily needs to go in property-init.ly.  I can't give a good
> recommendation yet, because I'm not clear enough on how this will be used.
>  
At the moment, this seems to be used as a workaround for glissandos, see
Federico's
mail that started this thread. On the short side, since coding multiple
glissando lines
spanning between two chords requires some hackery, the definition of a handy
shortcut is the minor problem and could be left to the user. On the long
term, it would be
great if lilypond allows for multiple glissando lines at once, and then,
this command is
not needed anymore. But if anyone disagrees, I still can include this in
ly/property-init.ly
or wherever.
> For right now, you might want to define \hideTabNoteHead in tablatures.ly,
> rather than property-init.ly.
>
>  
We don't have tablature.ly, do we? We dropped that file in 2.13.4 by
establishing
scm/tablature.scm and moving the switches for tabNumbersOnly/tabFullNotation
to ly/property-init.ly.

Marc