Patch: remove Ottava_spanner_engraver from \TabStaff

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Patch: remove Ottava_spanner_engraver from \TabStaff

Marc Hohl
Hi all,

Raphaël Doursenaud has pointed me to an error in tablature:
showing the ottava spanner in tablature doesn't make any sense,
so I removed it. Is this patch ready to be applied?

Marc





0002-tablature-enhancement-remove-Ottava_spanner_engrave.patch.gz (904 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Patch: remove Ottava_spanner_engraver from \TabStaff

Marc Hohl
Marc Hohl schrieb:
> Hi all,
>
> Raphaël Doursenaud has pointed me to an error in tablature:
> showing the ottava spanner in tablature doesn't make any sense,
> so I removed it. Is this patch ready to be applied?
I reworked my patch slightly; now the new behavior (and the improved
multi measure rest handling) is documented in a regression test file.

Ready to be applied?

Marc

>
> Marc
>
>
>
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> lilypond-devel mailing list
> [hidden email]
> http://lists.gnu.org/mailman/listinfo/lilypond-devel
>  


0001-tablature-fix-ottava-bracket-error.patch.gz (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Patch: remove Ottava_spanner_engraver from \TabStaff

Marc Hohl
Neil Puttock schrieb:

> 2009/11/6 Marc Hohl <[hidden email]>:
>
>  
>> Ready to be applied?
>>    
>
> LGTM.
>
> I don't think these comments are necesary though:
>
> +  %% No key in tablature!
>  
There was already a "no accidentals" comment in it,
so for the sake of consistency, I added the others.

I added another version of my patch without these comments;
I tried to fill the [DOCME] in the description tag with something more
useful.

Thanks,

Marc
> +  %% No string numbers ;-) !
>
> +  %% No ottava spanners
>
> Regards,
> Neil
>
>  


tablature-fix-ottava-bracket-error.patch.gz (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Patch: remove Ottava_spanner_engraver from \TabStaff

Marc Hohl
Neil Puttock schrieb:

> 2009/11/9 Marc Hohl <[hidden email]>:
>
>  
>> I added another version of my patch without these comments;
>> I tried to fill the [DOCME] in the description tag with something more
>> useful.
>>    
>
> Cheers, it's applied.
>  
Thank you!

Marc
> Regards,
> Neil
>
>  



Loading...