[Patch] NR: Documentation of harmonics and slides

classic Classic list List threaded Threaded
11 messages Options
Reply | Threaded
Open this post in threaded view
|

[Patch] NR: Documentation of harmonics and slides

Patrick Schmidt-3
Hi Carl,

here is a patch covering the new functions for harmonics and a new  
snippet for slides. I did not manage to upload it to Rietveld as I  
obviously didn't understand the meaning of the following sentence in  
the CR:

"Add the ‘git-cl/’ directory to your PATH, or create a symbolic link  
to the git-cl and upload.py scripts in one of your PATH directories  
(such as ‘$HOME/bin’). "

I created two files (one for git-cl and one for upload.py) in /Users/
PLS/bin, e.g.:

#!/bin/bash

exec /Users/PLS/git-cl/git-cl "$@"

and made it (them) executable with chmod +x git-cl. Then I cded to  
lilypond-git and entered:

git cl config

This is the error I got:

pls:~/git-cl PLS$ git cl config
   File "/Users/PLS/git-cl/git-cl", line 95
     self.cc = ','.join(x for x in (self.cc, more_cc) if x)
                            ^
SyntaxError: invalid syntax

This is probably a silly mistake. Any pointer is very much  
appreciated (Mac OS 10.4.11).

My patch does neither contain the open-string harmonics reference nor  
the fretted-string harmonics snippet I sent you in another email.  
IINM these snippets should be added to LSR first and then you could  
still decide whether they should become part of the docs and -- if  
yes -- where to place them. Unfortunately the LSR seems to be down at  
the moment.

Marc Hohl sent me a link to another nice feature you wrote:  
\chordGlissando. Is there any reason not to include this function in  
2.13.42/43. Is there anything I can do to make it happen. At least I  
can offer to do the documentation.

Thanks for your help,

patrick


0001-NR-harmonics-and-slides.patch (4K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [Patch] NR: Documentation of harmonics and slides

Carl Sorensen



On 12/10/10 1:23 PM, "Patrick Schmidt" <[hidden email]> wrote:

> Hi Carl,
>
> here is a patch covering the new functions for harmonics and a new
> snippet for slides.

I'll try to get this reviewed and posted in the next day or so.


>I did not manage to upload it to Rietveld as I
> obviously didn't understand the meaning of the following sentence in
> the CR:

It's "CG" not "CR" :)

>
> "Add the Ogit-cl/¹ directory to your PATH, or create a symbolic link
> to the git-cl and upload.py scripts in one of your PATH directories
> (such as O$HOME/bin¹). "

If you look in the README in your git-cl directory, it recommends a symlink.

I did it with

cd ~/bin

ln -s ~/git-cl/git-cl/

But I don't know that this is the source of your problem.

>
> I created two files (one for git-cl and one for upload.py) in /Users/
> PLS/bin, e.g.:
>
> #!/bin/bash
>
> exec /Users/PLS/git-cl/git-cl "$@"
>
> and made it (them) executable with chmod +x git-cl. Then I cded to
> lilypond-git and entered:
>
> git cl config
>
> This is the error I got:
>
> pls:~/git-cl PLS$ git cl config
>    File "/Users/PLS/git-cl/git-cl", line 95
>      self.cc = ','.join(x for x in (self.cc, more_cc) if x)
>                             ^
> SyntaxError: invalid syntax
>

I suspect that this is a problem with the version of python you have
installed.  I'd do

python --version

and then check the version that your git-cl requires.

> This is probably a silly mistake. Any pointer is very much
> appreciated (Mac OS 10.4.11).
>
> My patch does neither contain the open-string harmonics reference nor
> the fretted-string harmonics snippet I sent you in another email.
> IINM these snippets should be added to LSR first and then you could
> still decide whether they should become part of the docs and -- if
> yes -- where to place them. Unfortunately the LSR seems to be down at
> the moment.

Unfortunately, we can't add snippets to the LSR unless they compile on the
stable version.  So we should probably go ahead and add them to the docs.
All we need to do is add them to Documentation/snippets/new and then put a
reference to them in the Selected Snippets of the NR for tablature.


>
> Marc Hohl sent me a link to another nice feature you wrote:
> \chordGlissando. Is there any reason not to include this function in
> 2.13.42/43. Is there anything I can do to make it happen. At least I
> can offer to do the documentation.

I'm not sure that \chordGlissando is up to LilyPond coding standards for
inclusion in the distribution.  It may be too much of a hack.  I'll post it
for review on Rietveld and see what the developers think.

Thanks,

Carl



Reply | Threaded
Open this post in threaded view
|

Re: [Patch] NR: Documentation of harmonics and slides

Patrick Schmidt-3

Am 11.12.2010 um 01:50 schrieb Carl Sorensen:

>
>
>
> On 12/10/10 1:23 PM, "Patrick Schmidt" <[hidden email]> wrote:
>
>> Hi Carl,
>>
>> here is a patch covering the new functions for harmonics and a new
>> snippet for slides.
>
> I'll try to get this reviewed and posted in the next day or so.
>
>
>> I did not manage to upload it to Rietveld as I
>> obviously didn't understand the meaning of the following sentence in
>> the CR:
>
> It's "CG" not "CR" :)
>
>>
>> "Add the Ogit-cl/¹ directory to your PATH, or create a symbolic link
>> to the git-cl and upload.py scripts in one of your PATH directories
>> (such as O$HOME/bin¹). "
>
> If you look in the README in your git-cl directory, it recommends a  
> symlink.
>
> I did it with
>
> cd ~/bin
>
> ln -s ~/git-cl/git-cl/
>
> But I don't know that this is the source of your problem.
>
>>
>> I created two files (one for git-cl and one for upload.py) in /Users/
>> PLS/bin, e.g.:
>>
>> #!/bin/bash
>>
>> exec /Users/PLS/git-cl/git-cl "$@"
>>
>> and made it (them) executable with chmod +x git-cl. Then I cded to
>> lilypond-git and entered:
>>
>> git cl config
>>
>> This is the error I got:
>>
>> pls:~/git-cl PLS$ git cl config
>>    File "/Users/PLS/git-cl/git-cl", line 95
>>      self.cc = ','.join(x for x in (self.cc, more_cc) if x)
>>                             ^
>> SyntaxError: invalid syntax
>>
>
> I suspect that this is a problem with the version of python you have
> installed.  I'd do
>
> python --version
>
> and then check the version that your git-cl requires.
I got it. I added "env" to the first line in git-cl:
#!/usr/bin/env python
# git-cl -- a git-command for integrating reviews on Rietveld
# Copyright (C) 2008 Evan Martin <[hidden email]>

That did the trick. So I'll try to upload the patch to Rietveld, now.

>
>> This is probably a silly mistake. Any pointer is very much
>> appreciated (Mac OS 10.4.11).
>>
>> My patch does neither contain the open-string harmonics reference nor
>> the fretted-string harmonics snippet I sent you in another email.
>> IINM these snippets should be added to LSR first and then you could
>> still decide whether they should become part of the docs and -- if
>> yes -- where to place them. Unfortunately the LSR seems to be down at
>> the moment.
>
> Unfortunately, we can't add snippets to the LSR unless they compile  
> on the
> stable version.  So we should probably go ahead and add them to the  
> docs.
> All we need to do is add them to Documentation/snippets/new and  
> then put a
> reference to them in the Selected Snippets of the NR for tablature.
I'll do that.

>
>
>>
>> Marc Hohl sent me a link to another nice feature you wrote:
>> \chordGlissando. Is there any reason not to include this function in
>> 2.13.42/43. Is there anything I can do to make it happen. At least I
>> can offer to do the documentation.
>
> I'm not sure that \chordGlissando is up to LilyPond coding  
> standards for
> inclusion in the distribution.  It may be too much of a hack.  I'll  
> post it
> for review on Rietveld and see what the developers think.
IMHO it's very useful for electric guitar scores and it is user-
friendly.

Thanks,
patrick
>
> Thanks,
>
> Carl
>
>
>



Reply | Threaded
Open this post in threaded view
|

Re: [Patch] NR: Documentation of harmonics and slides

Federico Bruni-2
Il giorno sab, 11/12/2010 alle 13.34 +0100, Patrick Schmidt ha scritto:
> > I'm not sure that \chordGlissando is up to LilyPond coding  
> > standards for
> > inclusion in the distribution.  It may be too much of a hack.
> I'll  
> > post it
> > for review on Rietveld and see what the developers think.
> IMHO it's very useful for electric guitar scores and it is user-
> friendly.

Not only electric guitar.. I write scores for acoustic guitar mainly and
in the last months at least a couple of times I happened to wish
LilyPond had such a feature.

I hope \chordGlissando will be accepted and included in the distribution
eventually.  If not, maybe Carl could provide a .ly file to include (as
we used to do with tablature.ly)?

Let us know :)
Thanks,
Federico



Reply | Threaded
Open this post in threaded view
|

Re: [Patch] NR: Documentation of harmonics and slides

Patrick Schmidt-3
In reply to this post by Patrick Schmidt-3
-------- Original-Nachricht --------
> Datum: Sat, 11 Dec 2010 14:19:01 +0100
> Von: Federico Bruni <[hidden email]>
> An: Patrick Schmidt <[hidden email]>
> CC: Carl Sorensen <[hidden email]>, "[hidden email]" <[hidden email]>
> Betreff: Re: [tablatures] Re: [Patch] NR: Documentation of harmonics and slides

> Il giorno sab, 11/12/2010 alle 13.34 +0100, Patrick Schmidt ha scritto:
> > > I'm not sure that \chordGlissando is up to LilyPond coding  
> > > standards for
> > > inclusion in the distribution.  It may be too much of a hack.
> > I'll  
> > > post it
> > > for review on Rietveld and see what the developers think.
> > IMHO it's very useful for electric guitar scores and it is user-
> > friendly.
>
> Not only electric guitar.. I write scores for acoustic guitar mainly and
> in the last months at least a couple of times I happened to wish
> LilyPond had such a feature.
So did I!
>
> I hope \chordGlissando will be accepted and included in the distribution
> eventually.  If not, maybe Carl could provide a .ly file to include (as
> we used to do with tablature.ly)?
Well, he already did. Here is the code and a test file.

HTH,

patrick
>
> Let us know :)
> Thanks,
> Federico
>
>
>

--
GRATIS! Movie-FLAT mit über 300 Videos.
Jetzt freischalten unter http://portal.gmx.net/de/go/maxdome

chord-glissando.ly (2K) Download Attachment
chord-gliss-tab.ly (465 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [Patch] NR: Documentation of harmonics and slides

Carl Sorensen
In reply to this post by Patrick Schmidt-3


On Dec 11, 2010, at 5:35 AM, "Patrick Schmidt" <[hidden email]>  
wrote:

>
> Am 11.12.2010 um 01:50 schrieb Carl Sorensen:
>
>>
>>
> I got it. I added "env" to the first line in git-cl:
> #!/usr/bin/env python
> # git-cl -- a git-command for integrating reviews on Rietveld
> # Copyright (C) 2008 Evan Martin <[hidden email]>
>
> That did the trick. So I'll try to upload the patch to Rietveld, now.


great!


>>>
>>
>> Unfortunately, we can't add snippets to the LSR unless they compile
>> on the
>> stable version.  So we should probably go ahead and add them to the
>> docs.
>> All we need to do is add them to Documentation/snippets/new and
>> then put a
>> reference to them in the Selected Snippets of the NR for tablature.
> I'll do that.

I'll look forward to it.

>>
>> I'm not sure that \chordGlissando is up to LilyPond coding
>> standards for
>> inclusion in the distribution.  It may be too much of a hack.  I'll
>> post it
>> for review on Rietveld and see what the developers think.
> IMHO it's very useful for electric guitar scores and it is user-
> friendly.
>

I'll post a patch for review today.

Thanks,

Carl


Reply | Threaded
Open this post in threaded view
|

Re: [Patch] NR: Documentation of harmonics and slides

Patrick Schmidt-3

Am 11.12.2010 um 14:43 schrieb Carl Sorensen:

>
>
> On Dec 11, 2010, at 5:35 AM, "Patrick Schmidt" <[hidden email]>
> wrote:
>
>>
>> Am 11.12.2010 um 01:50 schrieb Carl Sorensen:
>>
>>>
>>>
>> I got it. I added "env" to the first line in git-cl:
>> #!/usr/bin/env python
>> # git-cl -- a git-command for integrating reviews on Rietveld
>> # Copyright (C) 2008 Evan Martin <[hidden email]>
>>
>> That did the trick. So I'll try to upload the patch to Rietveld, now.
>
>
> great!
Ok, now I did:

git cl config

but I didn't know what to answer to the questions:

pls:~/lilypond-git PLS$ git cl config
Rietveld server (host[:port]) [codereview.appspot.com]:
CC list: [hidden email]
Tree status URL:
ViewVC URL:

According to the CG! ;-) that doesn't matter but I'd feel better if I  
knew.

Then I entered git pull -r and got one trailing whitespace error.  
Should I upload the patch anyway or is it still possible to amend the  
patch? (I will have to find an automated solution for trailing  
whitespaces in emacs.) What is the best procedure here?

>
>>>
>>> I'm not sure that \chordGlissando is up to LilyPond coding
>>> standards for
>>> inclusion in the distribution.  It may be too much of a hack.  I'll
>>> post it
>>> for review on Rietveld and see what the developers think.
>> IMHO it's very useful for electric guitar scores and it is user-
>> friendly.
>>
>
> I'll post a patch for review today.
Thanks!

patrick
>
> Thanks,
>
> Carl
>
>



Reply | Threaded
Open this post in threaded view
|

Re: [Patch] NR: Documentation of harmonics and slides

Carl Sorensen
On 12/11/10 7:16 AM, "Patrick Schmidt" <[hidden email]> wrote:

>
>
> Am 11.12.2010 um 14:43 schrieb Carl Sorensen:
>
>>
>>
>> On Dec 11, 2010, at 5:35 AM, "Patrick Schmidt" <[hidden email]>
>> wrote:
>>
>>>
>>> Am 11.12.2010 um 01:50 schrieb Carl Sorensen:
>>>
>>>>
>>>>
>>> I got it. I added "env" to the first line in git-cl:
>>> #!/usr/bin/env python
>>> # git-cl -- a git-command for integrating reviews on Rietveld
>>> # Copyright (C) 2008 Evan Martin <[hidden email]>
>>>
>>> That did the trick. So I'll try to upload the patch to Rietveld, now.
>>
>>
>> great!
> Ok, now I did:
>
> git cl config
>
> but I didn't know what to answer to the questions:
>
> pls:~/lilypond-git PLS$ git cl config
> Rietveld server (host[:port]) [codereview.appspot.com]:
> CC list: [hidden email]
> Tree status URL:
> ViewVC URL:
>
> According to the CG! ;-) that doesn't matter but I'd feel better if I
> knew.

I don't know either. ;-)

>
> Then I entered git pull -r and got one trailing whitespace error.
> Should I upload the patch anyway or is it still possible to amend the
> patch? (I will have to find an automated solution for trailing
> whitespaces in emacs.) What is the best procedure here?
>

git rebase --whitespace=fix HEAD

I have a code set in my .vimrc to delete trailing whitespace.

Here's a link that says how to do it in emacs:

<http://kerneltrap.org/Linux/White_Space>

HTH,

Carl



Reply | Threaded
Open this post in threaded view
|

Re: [Patch] NR: Documentation of harmonics and slides

Patrick Schmidt-3

Am 11.12.2010 um 15:24 schrieb Carl Sorensen:

> On 12/11/10 7:16 AM, "Patrick Schmidt" <[hidden email]> wrote:
>
>>
>>
>> Am 11.12.2010 um 14:43 schrieb Carl Sorensen:
>>
>>>
>>>
>>> On Dec 11, 2010, at 5:35 AM, "Patrick Schmidt" <[hidden email]>
>>> wrote:
>>>
>>>>
>>>> Am 11.12.2010 um 01:50 schrieb Carl Sorensen:
>>>>
>>>>>
>>>>>
>>>> I got it. I added "env" to the first line in git-cl:
>>>> #!/usr/bin/env python
>>>> # git-cl -- a git-command for integrating reviews on Rietveld
>>>> # Copyright (C) 2008 Evan Martin <[hidden email]>
>>>>
>>>> That did the trick. So I'll try to upload the patch to Rietveld,  
>>>> now.
>>>
>>>
>>> great!
>> Ok, now I did:
>>
>> git cl config
>>
>> but I didn't know what to answer to the questions:
>>
>> pls:~/lilypond-git PLS$ git cl config
>> Rietveld server (host[:port]) [codereview.appspot.com]:
>> CC list: [hidden email]
>> Tree status URL:
>> ViewVC URL:
>>
>> According to the CG! ;-) that doesn't matter but I'd feel better if I
>> knew.
>
> I don't know either. ;-)
Oh, wow, that makes me feel a little bit better! ;-)
>
>>
>> Then I entered git pull -r and got one trailing whitespace error.
>> Should I upload the patch anyway or is it still possible to amend the
>> patch? (I will have to find an automated solution for trailing
>> whitespaces in emacs.) What is the best procedure here?
>>
>
> git rebase --whitespace=fix HEAD
Thanks, but this command did not remove the whitespace, right?
>
> I have a code set in my .vimrc to delete trailing whitespace.
>
> Here's a link that says how to do it in emacs:
>
> <http://kerneltrap.org/Linux/White_Space>
Thanks, I'll see to that. (As a LaTeX user I never had to bother  
about trailing whitespaces before.)

Thanks again,

patrick
>
> HTH,
>
> Carl
>
>
>



Reply | Threaded
Open this post in threaded view
|

Re: [Patch] NR: Documentation of harmonics and slides

Carl Sorensen
On 12/11/10 9:27 AM, "Patrick Schmidt" <[hidden email]> wrote:

>
>
> Am 11.12.2010 um 15:24 schrieb Carl Sorensen:
>
>>>
>>
>> git rebase --whitespace=fix HEAD
> Thanks, but this command did not remove the whitespace, right?

Actually, this command *does* remove the whitespace.  If you do it twice in
a row you'll see the warnings the first time but not the second.

Thanks,

Carl



Reply | Threaded
Open this post in threaded view
|

Re: [Patch] NR: Documentation of harmonics and slides

Patrick Schmidt-3

Am 11.12.2010 um 17:35 schrieb Carl Sorensen:

> On 12/11/10 9:27 AM, "Patrick Schmidt" <[hidden email]> wrote:
>
>>
>>
>> Am 11.12.2010 um 15:24 schrieb Carl Sorensen:
>>
>>>>
>>>
>>> git rebase --whitespace=fix HEAD
>> Thanks, but this command did not remove the whitespace, right?
>
> Actually, this command *does* remove the whitespace.  If you do it  
> twice in
> a row you'll see the warnings the first time but not the second.

Good to know.

Thanks,
patrick
>
> Thanks,
>
> Carl
>
>
>